[Toybox] [PATCH] macOS: replace local strnstr with strcasestr.

[Rob Landley]

On 12/1/18 12:48 AM, enh wrote:
>> /opt/android/x86_64/bin/../sysroot/usr/include/stdlib.h:68:47: note: 'mktemp'
>>       has been explicitly marked deprecated here
>> char* mktemp(char* __template) __attribute__((deprecated("mktemp is unsa...
>>                                               ^
>> 1 warning generated.
>>
>> Why is it unsafe? (musl and glibc don't complain...)
> 
> dunno about musl, but glibc does (just at link time rather than
> compile time --- iirc we no longer have any link-time warnings in
> bionic, just compile time ones).

Um, _you_ added this warning in commit 40a09367f6f9.

-  if (d_flag ? !mkdtemp(template) : mkstemp(template) == -1) {
+  if (toys.optflags & FLAG_u) {
+    mktemp(template);

Why did you do that? (What's the issue you were trying to solve, exactly?)

Rob