[Toybox] [PATCH] Clean up some --help formatting.

enh enh at google.com
Tue Dec 4 14:48:08 PST 2018


since rob's so responsive right now, this seems like the best
opportunity there's ever been to stop the --help output irritating my
OCD on a daily basis!

i did choose to just ignore everything in pending for now, though.
On Tue, Dec 4, 2018 at 2:35 PM enh <enh at google.com> wrote:
>
> Be consistent about upper versus lower case. (Upper seems to have the
> majority, so I went with that, though I'm happy to provide the opposite
> patch as long as we're consistent!)
>
> Be consistent about using \t. (Though saving a few bytes seems like it
> might be better done in the code that generates help.h rather than
> directly in the source, since tabs make careful ASCII art layout hard
> enough that we regularly have things misaligned.)
>
> Remove trailing periods (most of which seem to have been added by me).
>
> Always use the US "human readable" rather than my British
> "human-readable", and be more consistent about declaring whether we're
> showing multiples of 1000 or 1024.
>
> Just say "verbose" rather than adding a useless "mode" or "output".
> ---
>  toys/android/log.c         |  4 ++--
>  toys/android/restorecon.c  | 10 +++++-----
>  toys/example/demo_number.c |  2 +-
>  toys/lsb/dmesg.c           |  2 +-
>  toys/lsb/hostname.c        | 10 +++++-----
>  toys/lsb/killall.c         | 10 +++++-----
>  toys/lsb/md5sum.c          |  4 ++--
>  toys/lsb/mount.c           | 14 +++++++-------
>  toys/lsb/pidof.c           |  4 ++--
>  toys/lsb/su.c              |  8 ++++----
>  toys/lsb/umount.c          |  8 ++++----
>  toys/net/microcom.c        |  2 +-
>  toys/net/netcat.c          | 14 +++++++-------
>  toys/net/netstat.c         | 18 +++++++++---------
>  toys/other/acpi.c          | 10 +++++-----
>  toys/other/base64.c        |  6 +++---
>  toys/other/bzcat.c         | 10 +++++-----
>  toys/other/chcon.c         |  6 +++---
>  toys/other/fmt.c           |  2 +-
>  toys/other/free.c          |  2 +-
>  toys/other/fsfreeze.c      |  4 ++--
>  toys/other/makedevs.c      |  2 +-
>  toys/other/mkpasswd.c      |  4 ++--
>  toys/other/nsenter.c       |  6 +++---
>  toys/other/readlink.c      | 10 +++++-----
>  toys/other/stat.c          |  2 +-
>  toys/other/uptime.c        |  2 +-
>  toys/other/watch.c         |  8 ++++----
>  toys/pending/stty.c        |  4 ++--
>  toys/posix/basename.c      |  4 ++--
>  toys/posix/chgrp.c         | 14 +++++++-------
>  toys/posix/cmp.c           |  4 ++--
>  toys/posix/comm.c          |  6 +++---
>  toys/posix/cp.c            | 34 +++++++++++++++++-----------------
>  toys/posix/cpio.c          | 14 +++++++-------
>  toys/posix/cut.c           | 16 ++++++++--------
>  toys/posix/df.c            |  4 ++--
>  toys/posix/du.c            | 20 ++++++++++----------
>  toys/posix/echo.c          | 22 +++++++++++-----------
>  toys/posix/file.c          |  4 ++--
>  toys/posix/grep.c          |  2 +-
>  toys/posix/iconv.c         |  4 ++--
>  toys/posix/id.c            |  2 +-
>  toys/posix/kill.c          |  2 +-
>  toys/posix/mkdir.c         |  8 ++++----
>  toys/posix/nl.c            |  4 ++--
>  toys/posix/paste.c         |  4 ++--
>  toys/posix/patch.c         |  4 ++--
>  toys/posix/ps.c            | 10 +++++-----
>  toys/posix/pwd.c           |  4 ++--
>  toys/posix/rm.c            |  6 +++---
>  toys/posix/sed.c           |  4 ++--
>  toys/posix/sort.c          | 30 +++++++++++++++---------------
>  toys/posix/tail.c          |  6 +++---
>  toys/posix/tee.c           |  4 ++--
>  toys/posix/time.c          |  4 ++--
>  toys/posix/touch.c         | 14 +++++++-------
>  toys/posix/tty.c           |  2 +-
>  toys/posix/uniq.c          | 16 ++++++++--------
>  toys/posix/uudecode.c      |  2 +-
>  toys/posix/uuencode.c      |  2 +-
>  toys/posix/wc.c            |  8 ++++----
>  62 files changed, 236 insertions(+), 236 deletions(-)



More information about the Toybox mailing list