[Toybox] [PATCH] Revert "Fix "ps -T 1234" to show thread belonging to that PID."

enh enh at google.com
Wed Jan 24 13:18:34 PST 2018


On Wed, Jan 24, 2018 at 1:14 PM, Rob Landley <rob at landley.net> wrote:
> On 01/24/2018 10:40 AM, enh wrote:
>>> You want it to go _back_ to this old behavior, the new one where it
>>> matches the other ps is wrong?
>>
>> having -AT broken breaks bug reports, because ps -AT is part of every
>> bug report. i need to revert this today, because bug reports must
>> work.
>>
>> having -T PID broken only hurts command-line users.
>
> Ok, reverted.

thanks!

>>> I see that in "ps -A 2273", the -A overrides the specific PID. I hadn't
>>> noticed that before. Is this the regression? You want -A to override
>>> PIDs listed on the command line?
>>
>> don't care. (ideally seems like that's an error, but procps seems to
>> agree that "-A wins", which i suppose makes a kind of sense given that
>> multiple -p filters are ORed together.)
>
> I don't use this feature. I got the output listing the right TIDs. My
> example uses cases are chromium and thunderbird running on my machine.

yeah, i assumed as much and followed up with an chrome-based example
of the bug. let me know if that's still not clear. (though a
first-order approximation is "do i see different COMMAND values for
different threads, with both -AT and -T PID"?)

> Alas, "diff -u <(ps -A) <(ps -AT)" requires _slightly_ more fiddling to
> get useful output for comparison. :)
>
> I'll take a look after work.
>
> Thanks,
>
> Rob



More information about the Toybox mailing list