[Toybox] [PATCH] ping: fix -q behavior.
enh at google.com
Fri Jul 6 13:19:27 PDT 2018
the networking folks said it probably doesn't matter. they did point
out that it's a lot easier to implement the toybox behavior with the
iputils ping than vice versa.
they said they'd be much more worried about whether we use IP_RECVERR
and parse ICMP errors correctly, or do link-local ping correctly...
On Thu, Jun 14, 2018 at 6:13 PM Rob Landley <rob at landley.net> wrote:
> On 06/14/2018 06:11 PM, enh wrote:
> > This matches iputils and busybox.
> I couldn't figure out what their -q was for. Those are printing the header and
> footer text so not "quiet", and it's continuing to ping after confirming the
> site is up so it's not "quick". The one I implemented is both quick and quiet:
> you don't have to > /dev/null to have no output, and if you're doing a script
> ala "if ping -q site; then echo site is up; fi" this returns as soon as it has a
> If you have a user that cares (including you personally) I'm happy to change it
> back, but I'd like to confirm because this deviation was intentional.
More information about the Toybox