[Toybox] [PATCH] basename: -s SUFFIX.

enh enh at google.com
Wed Nov 28 12:21:33 PST 2018


On Mon, Nov 19, 2018 at 10:45 AM Rob Landley <rob at landley.net> wrote:
>
> On 11/13/18 5:16 PM, enh wrote:
> > On Tue, Nov 13, 2018 at 2:58 PM Rob Landley <rob at landley.net> wrote:
> >> On 11/12/18 10:57 PM, enh wrote:
> >>> AOSP doesn't need -a specifically, but since it's needed for -s we may
> >>> as well accept it too.
> >>
> >> I would like to read along with the group: what git repo does the hermetic
> >> build stuff go into, and is there a starting commit I should look at?
> >>
> >> (The top level Android.mk in platform/system/core is "include $(call
> >> first-makefiles-under,$(LOCAL_PATH))" and given the lack of ordering of that
> >> if you _are_ doing a hermetic build it has to be set up before then, but I
> >> dunno how to go backwards from there...)
> >
> > any switch requires:
> >
> > 1. a symlink to toybox in prebuilts/build-tools/toybox/linux-x86/:
> > https://android-review.googlesource.com/c/platform/prebuilts/build-tools/+/822999
> >
> > 2. that soong be told that the tool now comes from toybox:
> > https://android-review.googlesource.com/c/platform/build/soong/+/822624
>
> I looked a bit more, and it mostly seems to be changes to this file:
>
> https://android.googlesource.com/platform/build/soong/+/master/ui/build/paths/config.go
>
> And this directory:
>
> https://android.googlesource.com/platform/prebuilts/build-tools/+/master/toybox/linux-x86
>
> Except... the directory is x86-only? You currently only support building on an
> x86 host, not on arm?

correct. i'll worry about supporting arm hosts when i have one that's
competitive with my 2x Intel(R) Xeon(R) Gold 6154 CPU @ 3.00GHz :-)

speaking of too slow to be useful... given that there's already some
__APPLE__ in the tree, i'm looking to see how hard it would be to at
least build those parts of toybox that are used in an AOSP build for
macOS.

> Rob



More information about the Toybox mailing list