[Toybox] [PATCH 2/2] macOS: use -E rather than -r for sed extended regular expressions.

[Rob Landley]

On 11/28/18 5:08 PM, enh wrote:
>> Applied, but this raises the question of whether $SED in make.sh is still
>> needed? (I applied a patch from a macos dev who said it worked, I had a mac but
> 
> (i don't --- i'm just borrowing one to see how realistic getting a mac
> toybox binary is. the answer seems to be that it's not _too_ bad,
> though there are linuxy tentacles even in things like cp and tail. but
> for my money, just having all our builds use the exact same sed would
> still be a win.)

I can probably do a dependency-free-ish scripts/sed.sh without _too_ much pain.

>> my apple store subscription was so screwed up an hour from a mac expert who knew
>> where the secret hidden error logs were couldn't get it unborked. I break
>> everything. Anyway, there patch used "gsed" instead of "sed", which is gnu sed.
>> The above wasn't using that because I forgot. :)
>>
>> If we don't need gsed, then $SED should probably be removed...
> 
> see my other mail. if you agree to the suggestion of an error, i'll
> send you another patch that adds an error if you're on a mac and not
> using gsed, and switches this to $SED.

Sounds good to me, but lemme take an evening to try to whip up a standalone
scripts/sed.sh build first...

Hmmm. Ugly first pass, but with the attached and:

cc -funsigned-char -I gsed -I . -Os -fno-strict-aliasing \
  -DTOYBOX_VERSION=\"no\" lib/*.c main.c toys/*/sed.c

I got what seems to be a functioning sed binary?

(I could generate most of that _with_ a sed invocation against generated/ so it
stays up to date each release, and really all the contents could be in one file
and the rest could just be "touch blah.h blah.h blah.h blah.h...")

The question is, does it build/run on macos? If so, I could add a compile-time
probe to build toybox sed if the host sed can't jump to a forward label and
stick it in the $PATH...)

>> Rob

Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gsed.tar.gz
Type: application/gzip
Size: 798 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20181128/ee8f7bcd/attachment-0001.gz>