[Toybox] ToT still broken...

enh enh at google.com
Thu Sep 20 12:46:07 PDT 2018


i see you fixed my file.c mistake (but don't appear to have seen my
patch --- is the list borked again?), but you've introduced a new one
since:

external/toybox/main.c:160:9: error: taking the absolute value of
unsigned type 'unsigned long' has no effect [-Werror,-Wabsolute-value]
    if (labs((unsigned long)toys.stacktop-(unsigned long)&which)>6000) return;
        ^
external/toybox/main.c:160:9: note: remove the call to 'labs' since
unsigned values cannot be negative
    if (labs((unsigned long)toys.stacktop-(unsigned long)&which)>6000) return;
        ^~~~
1 error generated.



More information about the Toybox mailing list