[Toybox] [PATCH] gzip: fix regressions caused by 7964e1f78b58d9c365361cc36b0422d9d56cd204.

Rob Landley rob at landley.net
Fri Apr 26 13:22:02 PDT 2019



On 4/26/19 12:49 PM, enh via Toybox wrote:
> The permissions preservation test still fails for me, but that seems to
> be because my environment changed: it's failing because of my umask.
> I'll fix that in a separate patch, since it's unrelated.

The test infrastructure should set umask to a known value, possibly before each
test. (If a test changes it, make sure it's changed _back_...)

We might also want to run the tests through some variant of "env -i". You saw
the environment sanitization trick I used in mkroot. (I really shouldn't be
sourcing the tests but running them as child processes, that makes cleanup much
easier. Historical baggage from when it was little, it's on the todo list...)

Rob



More information about the Toybox mailing list