[Toybox] [PATCH] main.c: fix unknown command handling.

Rob Landley rob at landley.net
Sat Aug 24 10:05:23 PDT 2019


On 8/22/19 3:09 PM, enh via Toybox wrote:
> Fix a crash (found when I accidentally had a symlink to a toybox that
> didn't support the command in question), and add disambiguating quotes
> to the error message.

You changed so much here I can't figure out what the crash was, let's see...

Ah, the symlink fallback logic goes "this is a symlink to toybox, yes" and gets
_confused_. (Fixed it a simpler way...)

But why did it _segfault_ though? I can go "toybox toybox toybox toybox toybox",
tested that first thing years ago. Yes the _behavior_ is wrong, but that
shouldn't be a _segfault_? It's only recursing into toybox_main() 2 levels deep
before going "boing". (Is there some way to disable the stupid glibc stack dump?
It's not helpful and it means I have to scroll up to see my debug printfs. Sigh,
the FSF is almost as helpy as my cat when it comes to programming.)

Hmmm...

Rob



More information about the Toybox mailing list