[Toybox] [PATCH] du.test: skip on Mac.

enh enh at google.com
Thu Dec 5 14:57:24 PST 2019


On Sun, Nov 24, 2019 at 1:13 AM Rob Landley <rob at landley.net> wrote:
>
> On 11/23/19 10:05 AM, enh wrote:
> >     So the right thing to do (in the absence of a generic way to test filesystem
> >     capabilities) is to test for a recognized filesystem type that supports them, I
> >     guess?
> >
> > It's worse than that, though, because SELinux is an option orthogonal to file
> > system, and this probably varies by macos version (assuming it isn't an option,
> > which I don't actually know --- case sensitivity is).
>
> I'm open to suggestions.

well, my suggestion is "disable this on the mac for now" :-)

i was curious about whether we could at least look at what file system
we're running on (because that's definitely part of the puzzle here),
but found that stat(1) just reports "unknown" on the Mac atm. i'll
send you a patch for that separately.

(fwiw, the du tests are broken on the mac for both filesystems
currently available to me, so this du.test hack still seems reasonable
[in the sense of "i don't think we have a better option right now"] to
me.)

> Unfortunately, I dunno how to distinguish "probe to see if the system is like
> this" and "probe to see if the command works". It's one of those things that's
> easy for a human to do, and hard to automate in generic-ish environment.
>
> (Then again my brain is kind of jello right now. At the end of a very busy 3
> weeks I flew 9 timezones and went off caffeine at the same time. Which I
> shouldn't have been back _on_ but the milk tea in japan is extremely alluring
> and available in 2 out of 3 vending machines and in every conbini. Plus I was
> flying with a sore throat because my usual "travel = sick" seems to have kicked
> in right as I was leaving this time. I've slept more than 12 hours/day since I
> got back and it's apparently not enough. So I'm not sure how much "can't see the
> solution right now" means at the moment...)
>
> Rob



More information about the Toybox mailing list