[Toybox] [PATCH] ifconfig.test: deflake.

[Rob Landley]

On 12/3/19 11:02 AM, enh via Toybox wrote:
> ::2 can legitimately be part of an IPv6 address, causing the test to
> fail because the grep matches an unrelated part of the output. Be more
> explicit about what we're actually searching for (as the previous test
> already was) to avoid flakiness.

If you have an english description of the test that's well under 80 characters,
why not just have that be the test description instead of a comment?

I tend to indent continuation lines.

I'm not sure what this is trying to accomplish:
  $ echo grep 10\.240\.240\.240
  grep 10.240.240.240

The shell eats the backslash and it's still a wildcard for grep. (This isn't a
quoting thing, this is an eval thing.)

Hmmm, I'd apply the attached (and continue on) except I don't have a qemu test
instance with the dummy driver set up. I should spend a half an hour doing that.
(Sigh. It's a pity Google never wanted to hire me to work on the test suite back
when I had spare time. I'm off doing j-core stuff again, I _think_ I fly back to
tokyo in a day or two? Waiting to hear how a planning meeting goes this evening...)

Rob

P.S. my blog is caught up to present! https://landley.net/notes.html has
yesterday's entry already for the first time in _years_. I'd like to thank the
academy, by which I mean the https://patreon.com/landley people who made my
lowest goal level, which was "get my development blog up to date"... You may
have noticed me posting slightly less here, since my constant toybox redesigns
and code frogging have been going there instead.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iftest.patch
Type: text/x-patch
Size: 2980 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20191204/249707d4/attachment-0003.bin>