[Toybox] [PATCH] ifconfig.test: deflake.

[Rob Landley]

On 12/4/19 11:31 AM, enh wrote:
> or, if you were actually asking "why didn't you *also* change \: to
> just :?", well, the \:\: was already in both lines, and it wasn't
> relevant to the change, and i thought it would confuse what the patch
> was actually fixing.

I'm familiar with the concept of cans of worms. :)

There was a time when people asked "how can I help" I'd point them at the test
suite. I... stopped doing that.

> i'd volunteer to tidy this whole test file up,

Oh I can do it. Eventually. It's on the todo list.

But it's one of the things I want to test under mkroot, and the mkroot tests
have turned into reestablishing an aboriginal linux baseline with the old lfs
plus getting toysh to a usable point, and I'm putting cycles into the latter
this week. (Looks like I fly out bright and early friday morning, so I get today
and tomorrow to work on that, and want to check soemthing _in_ before flying out
because it'll just get reverted again if I don't get to that point before I down
tools...)

> but in my copious free
> time i've actually written a readelf(1) that i need to make a last
> couple of changes to and send your way, plus we're coming up on
> another christmas and -- thanks to the other changes that happened in
> the meantime -- i'm even further away from sending you my man nroff
> subset than i was this time last year. and i still need to unpick my
> hexedit changes and send those and...

$ git diff | diffstat
 README                             |  169 --------------------
 b/lib/env.c                        |   48 +++--
 b/lib/xwrap.c                      |    9 -
 b/tests/ifconfig.test              |   37 +---
 b/tests/lsattr.test                |    7
 b/tests/sh.test                    |   43 ++++-
 b/tests/test.test                  |   10 +
 b/tests/timeout.test               |   57 ++++++
 b/tests/xxd.test                   |    2
 b/toys/example/demo_many_options.c |    1
 b/toys/lsb/mount.c                 |    2
 b/toys/other/base64.c              |    6
 b/toys/other/count.c               |    1
 b/toys/other/free.c                |    2
 b/toys/other/inotifyd.c            |    2
 b/toys/other/ionice.c              |   31 +--
 b/toys/other/lsattr.c              |    1
 b/toys/other/swapon.c              |    1
 b/toys/pending/brctl.c             |   27 +--
 b/toys/pending/expr.c              |   27 +--
 b/toys/pending/fold.c              |    2
 b/toys/pending/getty.c             |   43 ++---
 b/toys/pending/groupdel.c          |    2
 b/toys/pending/host.c              |   36 +---
 b/toys/pending/ipcrm.c             |   47 ++---
 b/toys/pending/ipcs.c              |   43 +----
 b/toys/pending/lsof.c              |   18 +-
 b/toys/pending/sh.c                |  309 ++++++++++++++++++++++++++-----------
 b/toys/pending/stty.c              |   47 ++---
 b/toys/pending/tftpd.c             |   37 +---
 b/toys/pending/tr.c                |    1
 b/toys/posix/cpio.c                |    4
 b/toys/posix/false.c               |    2
 b/toys/posix/getconf.c             |    2
 b/toys/posix/head.c                |    1
 b/toys/posix/patch.c               |   40 ++--
 b/toys/posix/sort.c                |   17 --
 b/toys/posix/tail.c                |   12 -
 b/toys/posix/test.c                |    3
 b/toys/posix/true.c                |    2
 b/www/design.html                  |   18 +-
 b/www/faq.html                     |  251 +++++++++++++++++++++++++++++-
 b/www/license.html                 |   14 +
 43 files changed, 882 insertions(+), 552 deletions(-)

Rob