[Toybox] [PATCH] ps, top: fix VIRT and SHR fields.

enh enh at google.com
Thu Feb 7 13:43:37 PST 2019


---
 toys/posix/ps.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/toys/posix/ps.c b/toys/posix/ps.c
index 079bdbd6..eff980f3 100644
--- a/toys/posix/ps.c
+++ b/toys/posix/ps.c
@@ -811,10 +811,9 @@ static int get_ps(struct dirtree *new)
     sprintf(buf, "%lld/statm", slot[SLOT_tid]);
     if (!readfileat(fd, buf, buf, &temp)) *buf = 0;

-    // Skip redundant RSS field, we got it from stat
-    for (s = buf, i=0; i<3; i++)
-      if (!sscanf(s, " %lld%n", slot+SLOT_vsz+i/2, &j)) slot[SLOT_vsz+i/2] = 0;
-      else s += j;
+    // Skip redundant RSS field, we got it from stat.
+    slot[SLOT_vsz] = slot[SLOT_shr] = 0;
+    sscanf(buf, "%lld %*d %lld", &slot[SLOT_vsz], &slot[SLOT_shr]);
   }

   // Do we need to read "exe"?
-- 
2.20.1.611.gfbb209baf1-goog
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ps-top-fix-VIRT-and-SHR-fields.patch
Type: text/x-patch
Size: 995 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20190207/74372ea8/attachment-0002.bin>


More information about the Toybox mailing list