[Toybox] [PATCH] top: make the column header span the terminal.

enh enh at google.com
Sat Feb 16 22:55:18 PST 2019


On Sat, Feb 16, 2019 at 2:25 PM Rob Landley <rob at landley.net> wrote:
>
> On 2/15/19 5:42 PM, enh via Toybox wrote:
> > This also makes everything more readable by separating out the -b no
> > formatting case.
>
> "%-*" works? Huh.
>
> You mixed tabs and spaces in the second hunk again. Fixed it up...

ugh, sorry. hopefully fixed on all my machines now...

> > The whitespace trimming for -b isn't strictly necessary, but it looks
> > weird if we output unnecessary spaces at the end of the line in -b mode,
> > and we've fixed it before, so let's not regress here. It also seems more
> > logical to do this in the one place where it actually happens.
>
> Your second hunk made me go top -o "" and sadly it ran, and your loop could
> traverse backwards into la-la land. But the _fix_ is probably to disallow an
> empty field list... done. (You can still do it in ps where it's silly but
> doesn't hurt anything that I am aware of.)
>
> Rob



More information about the Toybox mailing list