[Toybox] [PATCH] top: make the task/thread count add up.

[Rob Landley]

On 2/20/19 10:08 AM, enh wrote:
> On Wed, Feb 20, 2019 at 6:57 AM Rob Landley <rob at landley.net> wrote:
>>
>> On 2/17/19 12:54 AM, enh via Toybox wrote:
>>> Linux has more states than we were giving it credit for, which led to
>>> our numbers not adding up. Since the exact details seem to change
>>> between versions, and since having code specific to each kernel version
>>> is unattractive, go with the heuristic that there are relatively fewer
>>> "stopped" states (and they change less frequently), so all unknowns are
>>> "sleeping".
>>
>> I facepalmed at the help text update, but applied the commit as-is.
> 
> at least they haven't (yet) reused the same letter to mean different things :-/
> 
> i did consider leaving those states out of the help since they're
> unlikely to show up in top, but it seemed plausible that they'd show
> up in ps.

If you look at the su help text I'm trying to update from last post, I
documented -p but not -m, and didn't mention that - is a synonym for -l. The
code should _support_ them, but for toybox help text I'm trying to explain how
to use it.

There's some serious "terse vs complete and easily readable" tension going on.
I'm trying to get both but it's _hard_. I don't have as much space as a man
page, and even man pages are notoriously difficult.

Sigh. One of my patreon goals is doing "podcasts", which includes a seperate
video walkthrough for each toybox command. (Yes including stuff like "cat".) So
much stuff I'd love to do if I had spare time/energy instead of pouring
everything into $DAYJOB...

> sadly 3.13 was released in 2014, so it's another 2 years before we can
> pretend this never happened... (while looking up that date on
> https://en.wikipedia.org/wiki/Linux_kernel#Timeline i learned that
> there was a final 2.16 release in 2016!)

Bugfix releases don't count towards expiration, they're a large part of the
reason the timeout is so long in the first place.

Rob