[Toybox] make tests

enh enh at google.com
Mon Jan 7 16:43:39 PST 2019


yeah, return works.

patch attached (on the assumption that `return` also works on your older bash).

On Fri, Dec 28, 2018 at 11:38 AM Rob Landley <rob at landley.net> wrote:
>
> On 12/27/18 6:38 PM, enh wrote:
> > On Thu, Dec 27, 2018 at 12:14 PM Rob Landley <rob at landley.net> wrote:
> >> If we're not in a loop, continue should throw an error, then fall through to the
> >> exit. (That's what it does here...) You don't want to exit out of a loop because
> >> the loop will stop, but continue's a noisy NOP if you're not in a loop...
> >>
> >> Did bash grow a bug where redirecting stderr of continue breaks?
> >
> > no, it seems to be what i suggested before: bash doesn't believe it's
> > in a loop, presumably because of the intervening function.
>
> Possibly the continue should be a return now?
>
> > the error
> > is `continue: only meaningful in a 'for', 'while', or 'until' loop`.
> > (there are 'until' loops?)
>
> I have no idea, but should probably look it up for toysh.
>
> Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-return-rather-than-continue-to-make-bash-4.4-hap.patch
Type: text/x-patch
Size: 3526 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20190107/39ff8004/attachment-0002.bin>


More information about the Toybox mailing list