[Toybox] [PATCH] patch: add -s to the synopsis line and fix typos.

[enh]

On Sat, Jan 12, 2019 at 11:24 AM Rob Landley <rob at landley.net> wrote:
>
> On 1/12/19 11:05 AM, enh via Toybox wrote:
> > ---
> >  toys/posix/patch.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
>
> I have a todo item to add "fuzz" support, would this be useful?

maybe. i don't know yet. my strategy for moving things over has been
to just try a build locally, then to let the build bots tell me
whether the main build targets/branches build okay, then "submit and
see". in many cases that's worked fine (as far as we know), but in
other cases (such as patch) something that isn't built by default for
the main targets/branches breaks. then i revert the build change and
send patches or bug reports to you.

right now 33 tools are switched over, five or six passed the build bot
test and are waiting for "submit and see", sed needs a new prebuilt
with the -z change, and there's a cp bug i haven't had time to look at
yet:

--BEGIN QUOTE--
toybox cp seems to handle the permission bits for symlinks differently:

$ ls -al bootable/recovery/tests/testdata/testkey_v3.pk8
lrwxrwxrwx 1 tbao primarygroup 14 Apr  2  2018
bootable/recovery/tests/testdata/testkey_v3.pk8 -> testkey_v1.pk8
$ ls -al bootable/recovery/tests/testdata/testkey_v1.pk8
-rw-r--r-- 1 tbao primarygroup 1217 Apr  2  2018
bootable/recovery/tests/testdata/testkey_v1.pk8
$ rm testkey_v3.pk8 && cp
bootable/recovery/tests/testdata/testkey_v3.pk8 . && ls -al
testkey_v3.pk8
-rw-r----- 1 tbao primarygroup 1217 Jan  9 21:42 testkey_v3.pk8
$ rm testkey_v3.pk8 && toybox cp
bootable/recovery/tests/testdata/testkey_v3.pk8 . && ls -al
testkey_v3.pk8
-rwxr-x--- 1 tbao primarygroup 1217 Jan  9 21:42 testkey_v3.pk8
--END QUOTE--

but getting back to the point, yeah, now i know a build that's reliant
on patch(1) i'll examine that more thoroughly before i try it again.
i'm not sure yet whether they're relying on fuzz because (as evidenced
by the fact that i broke the build) i've never yet built that
particular target...

(so many of these things are really hard to search for too. "patch"
crops up far more often as a false positive than as an actual
reference to patch(1)...)

> Rob
> _______________________________________________
> Toybox mailing list
> Toybox at lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net