[Toybox] [PATCH] hostname: fix behavior when in jail.

Ed Maste emaste at freebsd.org
Wed Jan 30 11:07:03 PST 2019


On Wed, 30 Jan 2019 at 13:56, Rob Landley <rob at landley.net> wrote:
>
> On 1/30/19 11:13 AM, Ed Maste wrote:
> > On Sat, 19 Jan 2019 at 14:42, enh via Toybox <toybox at lists.landley.net> wrote:
> >>
> >> Only -d and -f should cause a DNS lookup. The rest should just act
> >> directly on the result of gethostname(3). Encountered with the AOSP
> >> buildbots' use of nsjail, but tested with both the Debian hostname and
> >> toybox hostname thus:
> >
> > Thanks, this also fixes hostname (no args) on FreeBSD for me.
>
> I'm not trying to get freebsd tests to pass this release.

Fair enough; I'm just going to (slowly) poke at improving the results
on FreeBSD, independent of release schedules.

> I dunno what to do about test suite things like the "root" group being called
> "wheel", except maybe running sed against etc/groups to read the name which
> seems overcoplicated and brittle?

Yeah, I'm not completely sure either; in my tree I switched root to be $ROOTGRP
https://github.com/emaste/toybox/commit/a576ccc4d035358bce0e40e37a7b4583e2c0d468
so that part could be committed upstream and I can carry a tiny local
patch to set ROOTGRP=wheel instead.



More information about the Toybox mailing list