[Toybox] [PATCH] blkid: adapt tests for util-linux blkid.

enh enh at google.com
Mon Jul 1 14:48:26 PDT 2019


(was your plan to commit this as a "TODO" for the toybox blkid? [in
which case i'll wait for that.] or was this just curiosity? [in which
case i'll probably add a "ignore failures for non-toybox tools" to my
test runner.])

On Tue, Jun 25, 2019 at 6:15 PM enh <enh at google.com> wrote:
>
> [PATCH] blkid.test: match TEST_HOST expectations.
>
> Missing SEC_TYPE for ext3, msdos, and vfat.
>
> Missing LABEL for f2fs and ntfs.
>
> Wrong endian of UUID for msdos, ntfs, and vfat.
> ---
>  tests/blkid.test | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> On Tue, Jun 25, 2019 at 4:32 PM Rob Landley <rob at landley.net> wrote:
> >
> > Locally I add failing tests as another way of tracking todo items, but don't
> > check them in.
> >
> > Send me the test that passes on the host?
> >
> > Rob
> >
> > On 6/25/19 3:46 PM, enh via Toybox wrote:
> > > (not sure what, if anything, you want to do about the missing stuff,
> > > but i thought that being able to run TEST_HOST is interesting/useful
> > > in its own right for toybox development. i'm pretty sure that stuff
> > > like SEC_TYPE is new since i last looked, for example. since Android's
> > > not using the toybox blkid anyway, i'll just keep moving...)
> > >
> > > On Tue, Jun 25, 2019 at 1:42 PM enh <enh at google.com> wrote:
> > >>
> > >> util-linux's blkid doesn't support reading from stdin, so move that to
> > >> being a special toyonly test rather than the default.
> > >>
> > >> toybox blkid differs from util-linux in that it doesn't seem to find the
> > >> LABEL for the checked-in example f2fs file system (the offset is wrong,
> > >> but also f2fs uses LE16 strings), nor does it support the SEC_TYPE that
> > >> util-linux blkid shows for several of the test file systems.
> > >> ---
> > >>  tests/blkid.test | 58 ++++++++++++++++++++++++++----------------------
> > >>  1 file changed, 31 insertions(+), 27 deletions(-)
> > > _______________________________________________
> > > Toybox mailing list
> > > Toybox at lists.landley.net
> > > http://lists.landley.net/listinfo.cgi/toybox-landley.net
> > >



More information about the Toybox mailing list