[Toybox] [PATCH] test.tar: fix tar tests on Android.

enh enh at google.com
Mon Jul 22 08:17:06 PDT 2019


ping?

On Thu, Jul 18, 2019 at 3:56 PM enh <enh at google.com> wrote:
>
> finally got back to this. new patch attached that fixes all the tests now...
>
>
> On Mon, Jul 8, 2019 at 10:05 PM Rob Landley <rob at landley.net> wrote:
> >
> > Yes please.
> >
> > (Sorry, hip deep in https://twitter.com/landley/status/1148345079565864960 and
> > https://twitter.com/landley/status/1148324286144425984 and
> > https://twitter.com/landley/status/1147267507344084992 and I keep frogging
> > functions when I figure out another aspect of the weirdness and my file of
> > corner case tests toysh has to pass is 300 lines line now and I'm still arguing
> > with token parsing and flow control...)
> >
> > Rob
> >
> > On 7/8/19 5:22 PM, enh wrote:
> > > do you want me to send another patch that only contains the fixes and
> > > doesn't include the workaround for the dd issue?
> > >
> > > On Wed, Jul 3, 2019 at 12:51 PM Rob Landley <rob at landley.net> wrote:
> > >>
> > >> On 7/1/19 4:26 PM, enh via Toybox wrote:
> > >>> There's no /etc/group on Android.
> > >>>
> > >>> Loop devices are in different places, but that test doesn't seem to
> > >>> offer anything beyond the block/char special device tests later, so
> > >>> remove that rather than fix it.
> > >>>
> > >>> Fix the block/char special tests (the expectations were missing, but
> > >>> they're never normally run on the host because the mknod fails).
> > >>>
> > >>> Likewise add the missing expectation to the "ownership" test, which
> > >>> isn't normally run on the host because the chown fails.
> > >>>
> > >>> Add a skipnot to the "sparse without overflow" test because the dd line
> > >>> doesn't work with toybox dd.
> > >>
> > >> I wrote "I need to fix that" and then left the window open, and haven't
> > >> continued through the patch list so as not to lose my place, and now it's the
> > >> following day...
> > >>
> > >> Rob
> > >



More information about the Toybox mailing list