[Toybox] [PATCH 1/2] killall.test: fix flakiness.

Rob Landley rob at landley.net
Thu Jul 25 19:33:16 PDT 2019


On 7/25/19 5:31 PM, enh via Toybox wrote:
> And when I say "fix", I mean "hack around in the worst possible way".
> 
> Android+mksh is often slow enough that we can do the pgrep before the
> killed process has actually exited. (I'm seeing roughly 100% failure
> rate on cloud x86 emulators, and about 75% on a real Pixel 2.)

Nah, that's not bad, that's just "force a schedule". If the process's parent
hasn't scheduled yet to receive the SIGCHLD then it'll still be a zombie, that's
understandable if your scheduler gives the new process scheduling priority
because shortest job first is likely. The tiny sleep _should_ be there.

Rob



More information about the Toybox mailing list