[Toybox] grep and empty regexes

[enh]

On Mon, Jul 29, 2019 at 12:11 PM Ed Maste <emaste at freebsd.org> wrote:
>
> On Mon, 29 Jul 2019 at 15:03, enh <enh at google.com> wrote:
> >
> > macOS, though,
> > definitely doesn't use the GNU one. i don't think they use the NetBSD
> > one either. theirs is the worst grep i've used since the early 1990s
> > at least.
>
> Yeah - macOS is using an older version of FreeBSD's non-default grep.
> (Almost?) all of the known issues have been fixed in FreeBSD after
> they took it, and we should be able to make it our default grep
> shortly. The -r option is definitely fixed :)

yeah, the current NetBSD one was fine; the move to toybox grep is
really just since it's our one-stop shop for everything. i don't know
how similar the NetBSD and FreeBSD greps are, but i did send NetBSD a
patch recently to fix an asan-found issue caused by fgetln().

(btw, i'd be curious to hear what your interest in toybox on FreeBSD
is and what your goals are there...)