[Toybox] one last find thing...

enh enh at google.com
Fri Jun 14 13:57:25 PDT 2019


(i haven't had time to investigate, and i don't have any useful test
case other than "some timezone testing fails to run on emulators in
the cloud, in a way that gives me no useful failure", but i'm getting
increasingly convinced that the DIRTREE_STATELESS patch does break
something, and it's not just an infrastructure issue... i wouldn't
normally send such a useless bug report, but i've failed to get to
this in 3 days, and i'm not likely to for at least 3 more at this
point, so i thought i'd at least mention it...)

On Tue, Jun 11, 2019 at 1:11 PM Rob Landley <rob at landley.net> wrote:
>
> On 6/10/19 4:54 PM, enh via Toybox wrote:
> > okay, so with the -true/-false patch i can build AOSP with toybox
> > find. but i still get those warnings i mentioned years (?) ago but
> > only this morning actually have chance to dig into...
> >
> > add something like this to tests/find.test:
> >
> > +ln -s does-not-exist dir/dangler
> > +ln -s looper dir/looper
> > +testing "-L dangling symlink" "find -L dir -name file 2>&1" "dir/file\n" "" ""
> >
> > basically, TEST_HOST will warn about looper but not about dangler.
> > toybox will warn about both. presumably a new DIRTREE_ flag needed?
> > possibly related to the existing issue with ls warnings when it can't
> > stat?
> >
> > sounds like something i should leave to you...
>
> I added a DIRTREE_STATLESS flag and made ->again = 2 mean we couldn't stat it
> (in which case ->st is memset to zero), but now I'm trying to work out how to
> test it. If I mkdir sub, cd into that and touch some files, and then chmod -r .
> or chmod -x r and "ls" with the debian one I get:
>
>   $ ls
>   ls: cannot open directory '.': Permission denied
>
> I'm trying to reproduce the ??? state here, but I've only ever seen it on things
> like floppy disks with bad sectors and truncated loopback mount images. Kinda
> want one in the test suite. Hmmm...
>
> Rob



More information about the Toybox mailing list