[Toybox] [PATCH] vi.c double_list based implementation.

[jarno Mäkipää]

Alright I have
ubuntu 18.10 with gcc 8.2.0
and
Archlinux with gcc 8.2.1

both builds fine with freshly cloned repo and commands
make distclean
make defconfig
make vi

I can set up virtual image with ubuntu 14.04 perhaps tomorrow. what
compiler version you might be using?

-Jarno

On Sat, Mar 23, 2019 at 9:59 PM Rob Landley <rob at landley.net> wrote:

> I just did:
>
>   make distclean
>   make defconfig
>   make vi
>
> On ubuntu 14.04.
>
> Rob
>
> On 3/23/19 2:27 PM, jarno Mäkipää wrote:
> > Hello
> >
> > Sorry I just build with default build flags made by:
> > make menuconfig
> > make
> >
> > Do you have instructions on some page what build flags should normally
> be set
> > on? So I can fix those few errors.
> >
> > -Jarno
> >
> >
> > On Sat, Mar 23, 2019 at 8:59 PM Rob Landley <rob at landley.net
> > <mailto:rob at landley.net>> wrote:
> >
> >     On 3/23/19 6:37 AM, Jarno Mäkipää wrote:
> >     > Has beginnings of reading file, saving file, hjkl movement,
> insert, ex
> >     > (only w, wq, q!), search with /, some other normal mode actions
> (dd, w, b,
> >     > e), some utf8 support
> >
> >     Compile vi....toys/pending/vi.c: In function 'run_vi_cmd':
> >     toys/pending/vi.c:409:3: error: 'for' loop initial declarations are
> only allowed
> >     in C99 mode
> >        for(int i=0;i<7;i++) {
> >        ^
> >     toys/pending/vi.c:409:3: note: use option -std=c99 or -std=gnu99 to
> compile your
> >     code
> >     toys/pending/vi.c: In function 'draw_page':
> >     toys/pending/vi.c:657:7: error: 'for' loop initial declarations are
> only allowed
> >     in C99 mode
> >            for(int p = 0; p < scr_buf->line->str_len;y++) {
> >            ^
> >     toys/pending/vi.c: In function 'utf8_len':
> >     toys/pending/vi.c:854:3: error: 'for' loop initial declarations are
> only allowed
> >     in C99 mode
> >        for(int i = len-1;i>0;i--) {
> >        ^
> >     lib/lib.c: In function 'parse_formats':
> >     lib/lib.c:1563:3: error: implicit declaration of function 'check_tm'
> >     [-Werror=implicit-function-declaration]
> >        check_tm(&tm);
> >        ^
> >     lib/lib.c: At top level:
> >     lib/lib.c:1482:12: warning: 'parse_formats' defined but not used
> >     [-Wunused-function]
> >      static int parse_formats(char *str, time_t *t, int *nano)
> >                 ^
> >     cc1: some warnings being treated as errors
> >     make: *** [vi] Error 1
> >
> >     Rob
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20190323/be5baccb/attachment-0001.htm>