[Toybox] bc broken

Daniel Rosenberg drosen at google.com
Mon Mar 25 16:13:39 PDT 2019


Found the issue. strcopy is copying the string past the null character.

On Thu, Mar 21, 2019 at 3:54 PM enh <enh at google.com> wrote:

> commit 1a3c65c868b676c86073025465f57116d0e91881 broke bc... there's no
> output any more from, say, `1+1`...
>
> i had a look through the diff, but it wasn't obvious what the active
> ingredient was. the tests still pass, and that seems legit --- only
> input stdin is broken. files work fine (with or without -l).
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20190325/587254e3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-bc_vec_concat.patch
Type: text/x-patch
Size: 779 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20190325/587254e3/attachment-0003.bin>


More information about the Toybox mailing list