[Toybox] [PATCH] Pass cflags and hostcc in mkroot.

[Rob Landley]

On 10/14/19 4:09 PM, Rob Landley wrote:
>> Nah it makes perfect sense now. Config scripts are somewhat spaghetti but mkroot
>> gets close to a right abstraction level.
> 
> Passing through HOSTCC makes sense, but passing through CFLAGS... is it
> HOSTCFLAGS or CROSS_CFLAGS?

Except now that I sit down to do it (in the kernel HOSTCFLAGS is a variable and
CFLAGS seems to go to the cross compiler, modulo whatever EXTRA_CFLAGS and
HOST_EXTRACFLAGS do), there's a design problem:

The airlock step already wrapped the compiler. If you're specifying HOSTCC then
that should be what was wrapped? (But if you do put the flags in the $HOSTCC
name, I'm not sure how to teach the airlock to wrap that...)

Specifying HOSTCC="/path/to/thingy --options" on the command line bypasses the
airlock step entirely, so it'll wrap the hostcc it finds but then use something
else. :) That's ugly but works.

Similarly, although toybox has $SED to let you use gsed, mkroot doesn't. It's
kinda aimed at a common case and adding too many weird knobs to it might defeat
the purpose? I'm unsure.

Rob