[Toybox] [PATCH] ls: Ensure file names are separated by 2 spaces

Rob Landley rob at landley.net
Mon Oct 21 15:14:26 PDT 2019


On 10/18/19 2:59 PM, Andrew Ilijic wrote:
> Hi Enh,
> 
> (Below are the new tests and the failure output)
> I created 2 test cases to do a basic test of `-x` and `-C`. These
> tests pass for the host `ls` but not for Toybox's `ls`. You cant see
> the issue in `diff` but I recreated the test and `hexdump -C
> <test_file>` shows a trailing 1 - 2 spaces, depending on if you are on
> `master` or my patch. I need to modify my patch so that it does not
> add the 2 trailing spaces.

I committed your patch yesterday, it should be in master already?

https://github.com/landley/toybox/commit/0b34a5637d91

(And then I left this window open over the weekend and now it's monday. I don't
remember when I committed your patch.)

> How should I submit these changes, all at once or multiple patches?

I haven't seen your patch to remove the trailing spaces? (Maybe it's in the
email I haven't read yet, but you didn't send it before this email...)

Ro



More information about the Toybox mailing list