[Toybox] [PATCH] find: support -printf \0 octal escapes and \c.

[enh]

On Wed, Sep 4, 2019 at 2:17 PM Rob Landley <rob at landley.net> wrote:
>
> On 9/3/19 12:08 PM, enh wrote:
> >> This is why I wait for people to complain before opening various cans of worms,
> >> _but_ once I'm implementing something I try to do it right. (I.E. if I'm gonna
> >> support \0, do it as a side effect of octal.)
> >
> > (that's what my patch does, btw.)
>
> It's a pity gmail suppresses "redundant" copies of email so that when I'm cc'd
> on a message some messages randomly go into the mailing list and some go into my
> inbox (depending on which copy raced to be delivered first) and the thread is
> chopped up so if I go "thread view" I can't get to the original message with the
> patch we're discussing.
>
> But gmail's been broken this way for a full decade now and has ignored all
> attempts at telling them we'd like an option for it NOT to try to "help out"
> this way. It's my fault for not having moved off of gmail yet...
>
> Anyway, dug it up and applied. Still need to look at merging the 3 instances...
>
> >> And if I _can_ implement things using common code (such as collating the 3
> >> implementations here), and this winds up implementing extra features, I'm not
> >> going to spend code _disabling_ the extra features. (That's why just about every
> >> toybox command line numerical input supports units.)
> >
> > i agree in general, i'm just not sure for this specific case to what
> > extent (if any) folks are relying on where exactly an escape ends.
> > (and we already have multiple interpretations of "\xdv", for example.)
>
> Then I need to catalog and document the differences.

that's what i've been doing in the tests...

> (And see if making all 3
> behave consistently would break anything.)

...but this is the part where i'm not sure exactly what we can do.
other than "suck it and see".

if you're happy with "suck it and see", let me know if you're not
already looking at this and i'll have a look.

> > i'm much less worried about cases where the prevailing implementations
> > consider something an error.
>
> Me too. :)
>
> > we could always try unifying everything and then we'd have specific
> > motivating cases for anything we needed to undo. (i did wonder about
> > having a flags argument to unescape_buf. that would cover this.)
>
> Dunno. I need to get the linux from scratch build working under mkroot, then I
> need to automate the beyond linux from scratch build, so I'm throwing as many
> packages as I can against this mess.
>
> Ideally I'd do http://landley.net/aboriginal/about.html#hairball and build
> debian and such under toybox, but the "debian only builds under debian, fedora
> only builds under the _previous_ version of fedora it won't even build under
> itself, every portage ebuild in the entire gentoo tree is manually tagged with
> every architecture it's been made to work on so adding an architecture means
> touching every ebuild AND the base #includes are a horrible nested mess that
> even the gentoo developers no longer understand and yes I asked them _and_ sat
> down with Daniel Robbins twice when he was in austin to try to see if _he_
> understood it and let's just say he has a REASON he's doing funtoo instead of
> gentoo now"...

"Funtoo Linux was created by Daniel Robbins, the creator and former
Chief Architect of Gentoo Linux, in late 2007, as a means to get
Gentoo to build reliably"
https://www.funtoo.org/FAQ:How_Did_Funtoo_Begin

interesting. now i have a _technical_ reason not to touch gentoo with
a bargepole :-)

> Ahem. Linux From Scratch and Beyond Linux From Scratch. Test loads. Yay. Then AOSP.

to be clear: are you saying "let's get to where we can do these and
_then_ try suck it and see", or "let's suck it and see, and those
projects will tell us if/where we need to copy historical mistakes"?

> Rob