[Toybox] [PATCH] ln: add -T, use FLAG()

Jarno Mäkipää jmakip87 at gmail.com
Wed Sep 25 14:31:56 PDT 2019


This second patch should fix the -T allow only 2 args

All the previous test cases seems to pass. Should write test cases for this.

-Jarno

On Wed, Sep 25, 2019 at 11:40 PM Ryan Prichard <rprichard at google.com> wrote:
>
> It looks like coreutils and busybox allow only 2 args with -T. Do we need to diagnose this?
>
> touch A B
> ln -sfT A B L
> ln: extra operand 'L'
>
> busybox ln -sfT A B L
> ln: -T accepts 2 args max
>
> toybox ln -sfT A B L
> ls -l L
> lrwxrwxrwx 1 rprichard primarygroup 1 Sep 25 13:38 L -> B
>
> With this patch, ln is overwriting the symlink twice, leaving it pointing at B.
>
> -Ryan
>
>
> On Wed, Sep 25, 2019 at 1:21 PM Jarno Mäkipää <jmakip87 at gmail.com> wrote:
>>
>> Added: -T
>> Replaced: & flag_# with FLAG(#)
>>
>> There was feature request on github. Apparently there is some android
>> scripts with ln -sfT
>>
>>
>> -Jarno
>> _______________________________________________
>> Toybox mailing list
>> Toybox at lists.landley.net
>> http://lists.landley.net/listinfo.cgi/toybox-landley.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ln-fix-T-to-accept-only-2-args.patch
Type: text/x-patch
Size: 857 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20190926/101718ae/attachment-0003.bin>


More information about the Toybox mailing list