[Toybox] [PATCH] cpio: fix tests by removing --trailer.

[enh]

oddly, this was the commit that added --trailer:

commit 32550751997db5b15baca56e72c54ed8ade53bd6
Author: Rob Landley <rob at landley.net>
Date:   Sun Jun 4 13:15:51 2017 -0500

    Don't add cpio TRAILER!!! entry by default, add new --trailer option if you
    want that. (This lets you concatenate cpio archives with "cat". Kernel's
    initramfs extractor doesn't need it.)

so it seems like you _thought_ you needed it, but actually didn't? (it
was added broken, so you've effectively lived without it since it was
added anyway.)

On Thu, Apr 16, 2020 at 8:56 AM enh <enh at google.com> wrote:
>
> f2866cf58a07c9d681ecd6695ea969ac70e59a3d fixed the cpio --trailer check
> as it claimed to, but doing so changed our behavior (since it used to be
> always-on and is now off unless you supply --trailer).
>
> This broke one of the cpio tests.
>
> Since I can't find any other cpio that has a --trailer option (or its
> inverse), this patch removes --trailer. This reverts our behavior to
> our old behavior (always include the trailer). Judging by the fact that
> the cpio tests pass with TEST_HOST=1, this seems to be the expected
> behavior.
> ---
>  toys/posix/cpio.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)