[Toybox] Small issue with mount option syntax: "mount -a -t noblah, blah"

Andy Hu andyhu at google.com
Tue Dec 15 12:24:46 PST 2020


# toybox mount -a -t nomsdos,smbfs
returns error "bad typelist". Toybox seems to expect
# toybox mount -a -t nomsdos,nosmbfs
as commented in lib/portability.c:134
// If one -t starts with "no", the rest must too

Most manuals and implementations of mount have, quote:
              More than one type may be specified in a comma-separated list,
              for the -t option as well as in an /etc/fstab entry.  The list
              of filesystem types for the -t option can be prefixed with no
              to specify the filesystem types on which no action should be
              taken.  The prefix no has no effect when specified in an
              /etc/fstab entry.
              The prefix no can be meaningful with the -a option.  For
              example, the command

                     mount -a -t nomsdos,smbfs

              mounts all filesystems except those of type msdos and smbfs.
------ end quote ------
I couldn't find specifications on how prefixing no with each type, or some
types should be handled. Suggest making a patch for the time being:
1. leading "no" in whole string negates all types
2. skip prefix "no" if leading "no" (in case there are people using the
syntax mount -a -t nomsdos,nosmbfs).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20201215/627fe6a0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mount-a-t-no-negates-all-listed-types.patch
Type: text/x-patch
Size: 1130 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20201215/627fe6a0/attachment.bin>


More information about the Toybox mailing list