[Toybox] [PATCH] chmod.test: make the tests a bit more robust.

enh enh at google.com
Tue Dec 15 10:59:50 PST 2020


If a chmod test fails it can leave files/directories in a state
that causes successive runs to suffer bogus failures, and that `make
clean` can't clean up without manual intervention.

Also, macOS seems to disallow +s in /tmp (but not otherwise), so
allow those tests to be skipped. This is why I was seeing macOS
test failures locally (because I pretty much always work on toybox
in /tmp) that we weren't seeing on the github CI runs (which
presumably don't run in /tmp).

With this, all the tests are passing locally for me on macOS again.
---
 tests/chmod.test | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20201215/abab6767/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-chmod.test-make-the-tests-a-bit-more-robust.patch
Type: application/octet-stream
Size: 2383 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20201215/abab6767/attachment-0002.obj>


More information about the Toybox mailing list