[Toybox] [PATCH] Canonicalize the usage: lines for the POSIX toys.

Rob Landley rob at landley.net
Sun Feb 2 00:03:01 PST 2020


On 2/2/20 12:16 AM, enh via Toybox wrote:
> This only touches 24 of the 68 toys/posix/ files --- the others were
> already canonical.
> 
> Potentially contentious, so worth stating explicitly, is that there
> were 8 matches for "COMMAND..." amongst all existing help output,
> with 7 matches for various inconsistent variants involving something
> with "ARG", so I resolved that in favor of using "COMMAND..." (which
> is also shorter overall, and avoids nested []s).
> ---
>  toys/posix/cal.c      | 2 +-
>  toys/posix/cat.c      | 4 ++--
>  toys/posix/chgrp.c    | 2 +-
>  toys/posix/cksum.c    | 2 +-
>  toys/posix/df.c       | 2 +-

Hmmm, that one isn't exactly a file though? (It can be a file, but is usually a
directory.)

>  toys/posix/du.c       | 2 +-
>  toys/posix/echo.c     | 2 +-
>  toys/posix/env.c      | 2 +-

Eh... grumble grumble. Not _wrong_ exactly...

>  toys/posix/file.c     | 2 +-
>  toys/posix/head.c     | 2 +-

arg vs args isn't worse, but abbreviating "number" to "num" seems harder on
non-english speakers? (Google translate isn't going to know what "num" means.)

>  toys/posix/kill.c     | 2 +-
>  toys/posix/logger.c   | 2 +-
>  toys/posix/ls.c       | 2 +-

In this case it often _is_ a file, so...

>  toys/posix/mkdir.c    | 2 +-

I suppose it's the DOS command, and "dirname" already wasn't easy on translation. :)

>  toys/posix/nice.c     | 2 +-
>  toys/posix/nohup.c    | 2 +-
>  toys/posix/patch.c    | 2 +-
>  toys/posix/renice.c   | 2 +-
>  toys/posix/rmdir.c    | 2 +-
>  toys/posix/tar.c      | 2 +-
>  toys/posix/tee.c      | 2 +-
>  toys/posix/time.c     | 2 +-
>  toys/posix/uniq.c     | 2 +-
>  toys/posix/uuencode.c | 4 ++--
>  24 files changed, 26 insertions(+), 26 deletions(-)

Sigh. Applied.

Rob



More information about the Toybox mailing list