[Toybox] [PATCH] chattr: fix exit status, redo the tests.

[Rob Landley]

On 2/5/20 5:54 PM, enh via Toybox wrote:
> The e2fsprogs chattr(1) returns failure when it fails to do what was
> asked of it, and so should we. Fixing this then reveals a lot of issues
> with the tests that were being accidentally swept under the carpet.

Applying: chattr: fix exit status, redo the tests.
error: patch failed: toys/other/lsattr.c:359
error: toys/other/lsattr.c: patch does not apply

Hmmm...

$ patch -p1 --dry-run -i 0001-chattr-fix-exit-status-redo-the-tests.patch
checking file tests/chattr.test
checking file toys/other/lsattr.c
Hunk #1 succeeded at 343 with fuzz 1 (offset -16 lines).

Ah, first line of last hunk is conflicting with the patch you  poinged me about. :)

And while figuring that out, I found out that toybox patch -x says success and
toybox patch will apply the patch... reverting that first line to the old
version out of the hunk. Sigh. That's a bug.

Rob