[Toybox] [PATCH] cp: fix -D (--parents)

Rob Landley rob at landley.net
Sun Feb 23 03:45:17 PST 2020


Sorry, flew back from Japan to Austin on tuesday am I'm still deep in the grip
of jetlag, and buried about 5 todo items deep.

Lemme try to get the patch fuzz fix committed, and then track down the use after
free in config2help, and then I can do this before getting back to the mkroot
and toolchain stuff from https://landley.net/notes.html#18-02-2020 and then I'd
think maybe I could get back to finishing the toysh variable expansion plumbing
(where did I leave off... I need to unify the quote traversal logic so I don't
have to teach two different places that $((echo hello) | wc) parses as $( ( ) )
and not $(( )), but I got distracted from that by implementing the "!" command
which is like ":" but doesn't have a base command name I can feed to NEWTOY()
and I can't do an OLDTOY() without a NEWTOY(), so there's design work...)

But it'll be monday by then and I should do $DAYJOB stuff again.

(While I'm at it, I need to figure out why ifconfig in mkroot called from toysh
is saying "ifconfig: bad argument '.0.2.15'" (is that a toysh bug or an ifconfig
bug), oh and I want to add xattr support to tar before the next release, which
is a month overdue. And I finished setting up the local debug environment for
the README->README.md conversion but didn't _do_ the conversion because I
haven't learned the new markup yet. Oh and md5sum is throwing a broken warning
with gcc 9 I can't typecast away so I need to turn a memset() into a for loop so
gcc can't understand what I'm doing enough to complain about it (I'm blanking
the second half of a struct after calculating the hash, I sorted the members so
this does what I want and yes it's intentional)), I wanted to make mount use
block2mtd with jffs2.img, swapon -a, test should learn the ~= regex match, the
can of worms that is faq.html...)

Rob

(P.S. I'm sorry I haven't reproduced
https://github.com/landley/toybox/issues/170 , yes I should get back to
https://github.com/landley/toybox/issues/166 , is
https://github.com/landley/toybox/issues/164 still active?)

On 2/21/20 11:00 AM, Jarno Mäkipää wrote:
> ping
> 
> On Sat, Feb 15, 2020 at 2:52 PM Jarno Mäkipää <jmakip87 at gmail.com> wrote:
>>
>> add test for -D
>> fix b/c/d/FILE not copying into a/ with -D option
>>
>> github.com/landley/toybox/issues/165
>> ---
>>  tests/cp.test   | 7 +++++++
>>  toys/posix/cp.c | 7 +++++--
>>  2 files changed, 12 insertions(+), 2 deletions(-)
> _______________________________________________
> Toybox mailing list
> Toybox at lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net
> 



More information about the Toybox mailing list