[Toybox] [PATCH] setsid: document -w.

enh enh at google.com
Fri Jan 10 16:17:36 PST 2020


-w was added recently. The change in behavior so we now always fork
means that it's needed in more cases too: other implementations of
setsid(1) only fork if getpgrp() != getpid(). This broke a script, which
is what made me notice the missing help.

This seems to have been an accidental change, and is contrary to what
the util-linux setsid(1) man page says: "The command calls fork(2) if
already a process group leader.  Otherwise, it executes a program
in the current process", but whether we change our behavior or not, we
should document the new option.
---
 toys/other/setsid.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/toys/other/setsid.c b/toys/other/setsid.c
index 57a926ef..70672424 100644
--- a/toys/other/setsid.c
+++ b/toys/other/setsid.c
@@ -14,6 +14,7 @@ config SETSID

     -d Detach from tty
     -c Control tty (become foreground process & receive keyboard signals)
+    -w Wait for child (and exit with its status)
 */

 #define FOR_setsid
-- 
2.25.0.rc1.283.g88dfdc4193-goog
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-setsid-document-w.patch
Type: text/x-patch
Size: 1194 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20200110/5cbfdcf5/attachment-0002.bin>


More information about the Toybox mailing list