[Toybox] Extra echo in mkroot for passwd

Rob Landley rob at landley.net
Fri Jan 17 20:54:10 PST 2020


On 1/17/20 4:59 PM, Denys Nykula wrote:
> Hi, 24ae822 scripts/mkroot.sh writes a bad passwd so my nightly couldn't su:
> 
>  cat > "$ROOT"/etc/passwd << 'EOF' &&
> -root::0:0:root:/root:/bin/sh
> +echo -e 'root::0:0:root:/root:/bin/sh
> 
>> ...
>> su: user 'root': Bad file descriptor
> 
> What change did you intend in this bit?

Sorry, explanation in commit fixing it.

> Also the output started having this line
> I don't remember from before when building without LINUX env set:
> 
>> === create x86_64-linux-musl-root.cpio.gz

I made it always recreate the cpio.gz so I can update userspace without having
to rebuild the kernel each time. (The cpio call is fast and resulting file isn't
that big. It's a packaging step.)

Rob



More information about the Toybox mailing list