[Toybox] [PATCH] lsattr: fix tests.

[enh]

On Mon, Jan 27, 2020 at 11:57 PM Rob Landley <rob at landley.net> wrote:
>
> On 1/27/20 10:37 PM, enh via Toybox wrote:
> > I'm trying to switch Android over to toybox chattr/lsattr from
> > e2fsprogs. Remove those tests that relied on being able to use
> > chattr(1), remove the duplication that tested both a bare name and a
> > full path, take into account all the flags that lsattr can now output,
> > and cope with the fact that the exact flags you'll see depend on your
> > file system. (Unfortunately this means trusting lsattr in the lsattr
> > tests, which isn't ideal, but without a known environment I don't think
> > we can do any better.)
>
> My todo diff in the file (just reverted) was:
>
> +#Problem:
> +#$ ./lsattr README
> +#------------- README
> +#$ lsattr README
> +#--------------e---- README
> +# Really needs a known filesystem type.
> +
>
> As for extents, is this the same as sparse file support? Because you can either
> have a sparse tarball or truncate -s. (Or truncate -s a file and then make a
> tarball with --sparse and see if the first 512 bytes generated header is right...)

i think so, but that only addresses ext file systems.

it did occur to me after i went to bed that having something like what
you have in the tar tests to strip out the bits you want to ignore
might be a good idea. so rather than add stuff to the expectations,
sed it out of the actual. similar to what i _did_ do for the -v tests,
where those are basically random numbers unless you can chattr, which
most folks won't be able to do in their environments.

(yes, i still need to fix the chattr tests.)

> I'd du but... xattr stuff. :(
>
> Rob