[Toybox] [PATCH] chattr.test: fix tests.

enh enh at google.com
Fri Jan 31 22:44:48 PST 2020


passes for me on an ext4 debian machine. and manually playing with
toybox and e2fsprogs chattr +i gets me identical results with both
lsattr implementations.

(they still pass if i apply the same change to chattr.test as you made
to lsattr.test too.)

i do have lsattr failures on an fs that doesn't support project ids,
and another that has different default flags on `.`. i'll send patches
tomorrow.

On Fri, Jan 31, 2020 at 7:09 PM Rob Landley <rob at landley.net> wrote:
>
> On 1/31/20 6:17 PM, enh via Toybox wrote:
> > Cope with all the extra flags added recently, and ignore random stuff
> > from the environment like extents and encryption.
> >
> > Tested on a cloud Android emulator with f2fs.
>
> I want to do a similar "collate sed calls" patch and remove trailing whitespace
> from the file, but...
>
> FAIL: chattr [-/+]i FILE[write]
> echo -ne '' | cd testattr && touch testFile &&
>          chattr +i testFile && lsattr testFile | clean &&
>          date > testFile 2>/dev/null; chattr -i testFile;
>          rm -rf testFile; cd ..
> --- expected    2020-01-31 21:11:10.815922683 -0600
> +++ actual      2020-01-31 21:11:10.819922683 -0600
> @@ -1 +1 @@
> -----i--------------- testFile
> +----i-------------- testFile
>
> It doesn't run for me before I did that? (off by one minus? Is it an ext4 thing?)
>
> Rob



More information about the Toybox mailing list