[Toybox] [PATCH 1/2] tar: don't recurse into excluded directories

William Djupström william at deepztream.com
Tue Jun 9 08:10:42 PDT 2020


On 09/06 09:56, Rob Landley wrote:
> I applied this locally, but what's a test case?
> 
>   $ mkdir -p boing/subb/ping
>   $ tar cvf boing.tar boing --exclude sub
>   boing/
>   boing/subb/
>   boing/subb/ping/
>   $ tar tvf boing.tar
>   drwxr-xr-x landley/landley   0 2020-06-09 09:50 boing/
>   drwxr-xr-x landley/landley   0 2020-06-09 09:50 boing/subb/
>   drwxr-xr-x landley/landley   0 2020-06-09 09:50 boing/subb/ping/
>   $ tar cvf boing.tar boing --exclude subb
>   boing/
>   boing/subb/
>   boing/subb/ping/

--exclude takes in a file containing exclusions
  
  $ mkdir -p skip/dir
  $ chmod 000 skip/dir
  $ ./toybox tar --exclude <(echo skip) -cf test.tar skip
  tar: skip/dir: Permission denied
  $ echo $?
  1

> 
> That's the host tar? Exact match on the name of the subdir...
> 
> (I really don't use --exclude much. I vaguely recall working out what it meant
> when I implemented it, but I appear to be misremembering. I just confirmed file
> vs dir doesn't make a difference here...)
> 
> Rob
> 

//William


More information about the Toybox mailing list