[Toybox] ls test breakage

Rob Landley rob at landley.net
Mon Oct 12 20:50:39 PDT 2020


On 10/12/20 7:55 PM, enh via Toybox wrote:
> haven't had chance to take a look, but this seems to have broken the ls tests
> (seen on the github CI but also reproduced locally):

Sigh. This is why my first dirtree_path() implementation was recursive. (Which
is unbounded stack usage on nommu systems...)

Although in this case it's because when name is null but !statless we need to
assign dt->name = 0 because the memset didn't do it. Which means the memset
doesn't need the +1...

Rob



More information about the Toybox mailing list