[Toybox] [PATCH] toys.h: remove unused declaration.

enh enh at google.com
Wed Oct 28 14:35:54 PDT 2020


On Wed, Oct 28, 2020 at 2:26 PM Rob Landley <rob at landley.net> wrote:
>
> On 10/28/20 10:47 AM, enh wrote:
> > yeah, i don't have any particular use for it myself, but i accept the
> > "behave more like the thing you're replacing" argument and i don't see
> > any problem that patch would cause, so "lgtm".
>
> It's an optimization problem that I'm not the target audience for. Tricksy.

yeah, same here. i didn't even know (before the bug reports/feature
requests came in), for example, that not everyone knows what "-" and
"--" usually mean.

> > mostly off topic, but personally i'd like to surface the "generally
> > applicable but not widely known and kind of annoying if we repeat it
> > everywhere it's relevant" stuff from --help:
> > ```
> > The filename "-" means stdin/stdout, and "--" stops argument parsing.
> >
> > Numerical arguments accept a single letter suffix for
> > kilo, mega, giga, tera, peta, and exabytes, plus an additional
> > "d" to indicate decimal 1000's instead of 1024.
> >
> > Durations can be decimal fractions and accept minute ("m"), hour ("h"),
> > or day ("d") suffixes (so 0.1m = 6s).
> > ```
> > but that shouldn't get in the way of this patch.
>
> Yup. It's in the toybox --help because I wanted to document it somewhere, but am
> not sure how to point people at it...

like i said, although i personally think this is a more interesting
problem, i don't think it should get in the way of submitting your
current patch which solves _a_ problem others are having :-)

> > the args parser knows whether there are numerical arguments so it
> > could automatically append the bit about suffixes everywhere it's
> > relevant, but the durations stuff isn't known, nor is whether any
> > argument is a filename. and, sadly, i've been surprised by the number
> > of people who don't know about `--` but would feel weird adding that
> > everywhere. i did wonder about having "Try `toybox --help` for general
> > information about arguments." automatically appended everywhere but i
> > don't actually know whether anyone who doesn't know the stuff above
> > would actually look, so i haven't suggested it. (until now.)
>
> Ok. Um. Hmmm. How about:
>
>   Toybox 0.8.4 multicall binary: https://landley.net/toybox (toybox --help)

i think part of the problem is that people don't know there's more
about argument parsing that they don't know, and much of `toybox
--help` is about installation and the like anyway. i also have strong
anecdata that people read man7.org more than they read any of toybox's
--help output anyway :-/

as i may have already said, i'm not sure _this_ problem even has a solution!

> And then I can change the top level toybox page from news.html to about.html
> except... looking at the about page again it's all FAQ entries, isn't it? I
> should just put an "about" section at the start of the FAQ, but although I can
> symlink index.html to any of the other pages I can't easily make it jump to an
> #anchor tag so it's not quite equivalent...
>
> While I'm at it I also need to collate the "general questions" to the end of the
> FAQ. Things like "why time based releases" and "will you backport old versions"
> are generic open source project questions, not really toybox specific. (In fact
> the second one I originally wrote for busybox, but after I left they made it
> busybox-specific and thus a less useful general answer to the question. In
> https://busybox.net/FAQ.html#backporting everything from "if you don't want to
> take the risk" to right before "the volunteers are happy" was not part of what I
> originally wrote. One of my motivations for doing a new FAQ...)
>
> Rob



More information about the Toybox mailing list