[Toybox] [PATCH] cpio: support reading concatenated cpio files.

Rob Landley rob at landley.net
Thu Apr 15 23:42:23 PDT 2021


On 4/16/21 12:18 AM, Rob Landley wrote:
> On 4/15/21 6:57 PM, Rob Landley wrote:
>> On 4/15/21 12:06 PM, enh wrote:
>>> do you already have the "do the right thing" patch ready, or should i send that
>>> today?
>>
>> I'm good, I'll try to get it in tonight. The hard part is the test suite, not
>> the implementation.
> 
> Correction: the hard part is I don't seem to have actually implemented hardlink
> support yet. It just records/extracts them as separate files.
> 
> Right. I need to test this against the kernel initramfs plumbing, in both
> directions...

     if (!strcmp("TRAILER!!!", name)) {
+      readall(afd, toybuf, 348);

Where did you get 348 from? (What is this change doing?)

I did what seems like a minimal change to continue past TRAILER!!! but error on
an empty archive, but I apparently don't understand what your change did? (I'm
assuming it fixed the use case you were seeing...?)

Rob


More information about the Toybox mailing list