[Toybox] [PATCH] Fix mount.test command string quoting

Yi-yo Chiang yochiang at google.com
Mon Feb 1 04:55:49 PST 2021


Use "" instead of '' to quote commands as the command contains expandable
variables.

I also found that most of the test cases are not working as intended.
Most of the test commands are like "mount ... >/dev/null 2>&1 && <do
something> && umount", so there is no visible output when mount succeeds or
fails, and the "testing" macro doesn't check return code, so the testcases
always passes no matter what. These test cases should be strengthened,
thoughts?
-- 

Yi-yo Chiang
Software Engineer
yochiang at google.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20210201/05d77454/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-mount.test-command-string-quoting.patch
Type: text/x-patch
Size: 1155 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20210201/05d77454/attachment.bin>


More information about the Toybox mailing list