[Toybox] [PATCH] netcat.test: reduce flake.

enh enh at google.com
Sat Feb 6 13:09:12 PST 2021


Starting two netcats at the same time and expecting them to be able to
talk to each is a little optimistic. I don't know whether `sleep .1`
will be sufficient, but wanted to try that before going to `sleep 1`
since neither the toybox nor the github nor the Android infrastructure
is running these tests in parallel, those seconds add up.

Right now this has a ~20% flake rate on the Android infrastructure. I
was able to reproduce the flake locally with `while true ; do make
test_netcat ; done` on my desktop before this patch, but not after.
(Though my desktop is way overpowered for just running that, whereas the
build servers tend to be pretty busy, which is why I reserve the right
to return later with a longer delay.)
---
 tests/netcat.test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20210206/af67a1e5/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-netcat.test-reduce-flake.patch
Type: text/x-patch
Size: 1486 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20210206/af67a1e5/attachment.bin>


More information about the Toybox mailing list