[Toybox] [PATCH] netcat.test: reduce flake.

enh enh at google.com
Mon Feb 8 10:46:56 PST 2021


On Sat, Feb 6, 2021 at 11:14 PM Rob Landley <rob at landley.net> wrote:

> On 2/6/21 3:09 PM, enh via Toybox wrote:
> > Starting two netcats at the same time and expecting them to be able to
> > talk to each is a little optimistic. I don't know whether `sleep .1`
> > will be sufficient, but wanted to try that before going to `sleep 1`
> > since neither the toybox nor the github nor the Android infrastructure
> > is running these tests in parallel, those seconds add up.
>
> Hmmm. In theory I could make it run the tests in parallel in different
> subdirectories. That's one of the reasons to move from having the test
> infrastructure source the tests to having it run them as child processes. I
> already added VERBOSE=nopass mode, and could have it collect error output
> into a
> variable it can printf all in one blob to avoid interleaving...
>
> I'll add it to the todo heap...
>

well, remember i already have my own wrapper around your tests to deal with
all the Android-specific stuff. i probably wouldn't benefit directly if you
did this anyway.

it's something i've been meaning to look at, but it's not enough of a
problem to warrant finding the time. (in particular, dealing with the "how
do i cleanly show the results?" problem.)


> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20210208/6a3b74da/attachment.html>


More information about the Toybox mailing list