[Toybox] [PATCH]ftpget: fix several bugs in ftpget.

[Rob Landley]

On 2/13/21 4:55 AM, Longjun Luo wrote:
> 1) One error between P and p configure options.

Is there a standard here you're conforming to other than "what busybox does"?

When I google for "ftpget" hit #5 is https://manned.org/ftpget/6964d88c which
uses lower case -p to set port number, and lftp at
https://linux.die.net/man/1/lftp also uses -p to set port number...

> 2) When I run ftpget with the option "-g", it transfers a file successfully but
> exits with code 1. After check the rfc document, I find ftp server will return
> 150 and then 226.

Tested with which ftp server(s)?

Rob

P.S. the switch from buf to toybox is a NOP because the one and only caller is
passing in toybuf, which is why I tend to inline this sort of thing during
cleanup...