[Toybox] [PATCH] df: -a should even show mounts we couldn't stat.

Rob Landley rob at landley.net
Sun Feb 14 04:17:19 PST 2021


On 2/13/21 5:45 PM, Rob Landley wrote:
> On 2/12/21 7:37 PM, enh via Toybox wrote:>> Also switch to FLAG() and capitalize POSIX.
> 
> I'm tempted to break that part out and apply it just so I can see what the rest
> of the changes are more clearly.
> 
> You want to print unstat-able devices with "-" as all of their human_readable()
> return values? And in-band signaling is not reliable because you have devices
> returning 0 as their major:minor? (This df.c isn't the only thing that's going
> to fail on that...)

Part of what's confusing me here is you're still skipping device 0:0, which is a
"should never happen" entry? (Even ramfs is only major 0 with minor incrementing
per-mount I think?)

Can we just change to print the - - - - entries for a device 0 0 and not have to
change the lib plumbing for the extra flag? Or am I missing something?

Rob

P.S. lanana.org is still there but if you click on the "linux device list" from
their main page it's 404. Gotta pull it out of archive.org...


More information about the Toybox mailing list