[Toybox] ltp test failure with toybox mv

[Rob Landley]

On 7/8/21 2:46 AM, Rob Landley wrote:
>> i scratched my head for a while about how to get that behavior in toybox
>> (assuming the resolution is to sigh, shake our fists at the clouds, and work
>> around this linux oddity), and it seems like we could use the fact that
>> error_msg() will have incremented toys.exitval, and add that to the CFG_MV `if`
>> above?
> 
> Sibling directories. If we're not stopping at one error then we may pop up one
> and descend down again, and THOSE we still want to delete. It's gotta either
> pass through the return code or the child needs to poke ->parent.
> 
> Sigh, I'll throw it on the todo heap. How time critical is this?
> 
> Rob
> 
> P.S. The logical thing to do is return DIRTREE_SAVE for the failure to delete
> and then have the parent check to see if it ->child is null...

Alright, I pushed a commit that passes the tests. (And added a -i test while I
was there.) Did several unrelated cleanups that I probably should have made into
a separate patch but I'm trying to get a release out before I vanish into
another $DAYJOB contract and the todo heap is teetering...

Did I fix it? Did I break it? My laptop hasn't got cgroups (or 2) mounted
because the whole point of devuan is NOT having systemd, and I still haven't got
mkroot to the point I can do tests in a toy environment under qemu.

Rob