[Toybox] [PATCH] md5sum.c: simplify the table setup slightly.

Rob Landley rob at landley.net
Wed Jun 9 16:53:34 PDT 2021

On 6/8/21 2:37 PM, enh via Toybox wrote:
> (Unrelated but nearby, I don't understand why anyone would ever want to
> calculate these tables at runtime, so this seems like another
> unnecessary CFG_TOYBOX_FLOAT to me, though an unusual one where we might
> want to _remove_ the floating-point code.)

It's good to show where they came from, and an embedded system with floating
point hardware that includes trig instructions can calculate the table in less
than 256 bytes of ROM. (Actual ROM tends to be sizes like 2k-8k where you count
every byte, at least at the process nodes I'm familiar with.)

*shrug* I could see it being a comment. The inconsistency between the different
hash functions (some being calculable and some not being calculable) is a rough
edge, and the world is much less likely to use these hashes in new boot ROMs and
such now that sha3 is out...


More information about the Toybox mailing list